Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the primary Pod Topology Spread Constraints based on label selector #806

Merged
merged 3 commits into from
Feb 13, 2021

Conversation

Nerja
Copy link
Contributor

@Nerja Nerja commented Feb 4, 2021

This PR adds rewrites of label selector values for Pod Topology Spread Constraints, similar to what we already have for PodAntiAffinity.

Fix: #801

@Nerja Nerja requested a review from stefanprodan as a code owner February 4, 2021 21:45
@Nerja Nerja force-pushed the fixedspreadconstraintssuffixes branch from 2cd6c58 to b41a270 Compare February 4, 2021 21:46
@codecov-io
Copy link

codecov-io commented Feb 4, 2021

Codecov Report

Merging #806 (76b73a6) into main (5cb343d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   56.83%   56.81%   -0.03%     
==========================================
  Files          67       67              
  Lines        5417     5418       +1     
==========================================
- Hits         3079     3078       -1     
- Misses       1879     1881       +2     
  Partials      459      459              
Impacted Files Coverage Δ
pkg/canary/deployment_controller.go 65.03% <100.00%> (+0.13%) ⬆️
pkg/canary/config_tracker.go 83.25% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb343d...76b73a6. Read the comment docs.

@stefanprodan
Copy link
Member

Hi @Nerja can you please update https://github.com/fluxcd/flagger/blob/main/docs/gitbook/faq.md#is-pod-affinity-and-anti-affinity-supported to reflect your latest changes and add topology to it? Thanks

marcus-rodan-sinch and others added 3 commits February 8, 2021 19:47
Added unit test assertions

Changed comment

Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
@Nerja Nerja force-pushed the fixedspreadconstraintssuffixes branch from 83a582d to 76b73a6 Compare February 8, 2021 18:48
@Nerja
Copy link
Contributor Author

Nerja commented Feb 8, 2021

@stefanprodan Found a moment during my vacation to add some info to the FAQ. Please have a look and let me know if we need to add more information.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Nerja 🥇

@stefanprodan stefanprodan added the kind/feature Feature request label Feb 13, 2021
@stefanprodan stefanprodan changed the title Added rewrite of Label Selectors on Pod Topology Spread Constraints Rewrite the primary Pod Topology Spread Constraints based on label selector Feb 13, 2021
@stefanprodan stefanprodan merged commit 10b5504 into fluxcd:main Feb 13, 2021
@Nerja Nerja deleted the fixedspreadconstraintssuffixes branch February 18, 2021 10:50
@Nerja Nerja restored the fixedspreadconstraintssuffixes branch February 18, 2021 10:50
@Nerja Nerja deleted the fixedspreadconstraintssuffixes branch February 18, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Label Selectors on Pod Topology Spread Constraints
4 participants