-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the primary Pod Topology Spread Constraints based on label selector #806
Rewrite the primary Pod Topology Spread Constraints based on label selector #806
Conversation
2cd6c58
to
b41a270
Compare
Codecov Report
@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 56.83% 56.81% -0.03%
==========================================
Files 67 67
Lines 5417 5418 +1
==========================================
- Hits 3079 3078 -1
- Misses 1879 1881 +2
Partials 459 459
Continue to review full report at Codecov.
|
Hi @Nerja can you please update https://github.com/fluxcd/flagger/blob/main/docs/gitbook/faq.md#is-pod-affinity-and-anti-affinity-supported to reflect your latest changes and add topology to it? Thanks |
Added unit test assertions Changed comment Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
83a582d
to
76b73a6
Compare
@stefanprodan Found a moment during my vacation to add some info to the FAQ. Please have a look and let me know if we need to add more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @Nerja 🥇
This PR adds rewrites of label selector values for Pod Topology Spread Constraints, similar to what we already have for PodAntiAffinity.
Fix: #801