Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: Added PodDisruptionBudget for the loadtester #819

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

Nerja
Copy link
Contributor

@Nerja Nerja commented Feb 18, 2021

This PR adds the ability to specify a PodDisruptionBudget for the loadtester similar to what we
have for the Flagger operator.

> helm template fl loadtester -f loadtester/values.yaml --set podDisruptionBudget.enabled=true
# Source: loadtester/templates/pdb.yaml
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
  name: fl-loadtester
spec:
  minAvailable: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: loadtester
---
# Source: loadtester/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: fl-loadtester
  labels:
    app.kubernetes.io/name: loadtester
    helm.sh/chart: loadtester-0.18.0
    app.kubernetes.io/instance: fl
    app.kubernetes.io/managed-by: Helm
...

@Nerja Nerja requested a review from stefanprodan as a code owner February 18, 2021 11:16
Signed-off-by: Marcus Rodan <marcus.rodan@sinch.com>
@Nerja Nerja force-pushed the loadtesterimprovements branch from dbdface to 596bb64 Compare February 18, 2021 11:16
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Nerja

@stefanprodan stefanprodan changed the title Added PodDisruptionBudget for the loadtester chart: Added PodDisruptionBudget for the loadtester Feb 22, 2021
@stefanprodan stefanprodan merged commit 6ab598d into fluxcd:main Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants