Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SMI v1alpha2 router #879

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Implement SMI v1alpha2 router #879

merged 1 commit into from
Apr 28, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Apr 8, 2021

This PR adds support for SMI TrafficSplit v1alpha2.

For service mesh providers that require this version set:

apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
  name: my-canary
spec:
  provider: "smi:v1alpha2"

Ref: #551
Ref: openservicemesh/osm#1081

Note that both v1alpha3 and v1alpha4 are backwards compatible with TrafficSplit v1alpha2. For newer versions the v1alpha2 must be set in the CRD e.g.:

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: trafficsplits.split.smi-spec.io
spec:
  group: split.smi-spec.io
  scope: Namespaced
  names:
    kind: TrafficSplit
    listKind: TrafficSplitList
    shortNames:
    - ts
    plural: trafficsplits
    singular: trafficsplit
  versions:
    - name: v1alpha4
      served: true
      storage: true
    - name: v1alpha3
      served: false
      storage: false
    - name: v1alpha2
      served: false
      storage: false

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Apr 26, 2021
@stefanprodan stefanprodan merged commit 927b432 into main Apr 28, 2021
@stefanprodan stefanprodan deleted the smi-v1lapha2-router branch April 28, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant