Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insecureSkipVerify option for Prometheus and Graphite #935

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Add insecureSkipVerify option for Prometheus and Graphite #935

merged 5 commits into from
Jun 15, 2021

Conversation

jahrlin
Copy link
Contributor

@jahrlin jahrlin commented Jun 15, 2021

this PR adds an option, insecureSkipVerify, that disables SSL certificate verification for the Prometheus and Graphite metric providers

Signed-off-by: Joakim Ahrlin joakim.ahrlin@embark-studios.com

Signed-off-by: Joakim Ahrlin <joakim.ahrlin@embark-studios.com>
@jahrlin jahrlin requested a review from stefanprodan as a code owner June 15, 2021 11:56
cmd/flagger/main.go Outdated Show resolved Hide resolved
pkg/apis/flagger/v1beta1/canary.go Outdated Show resolved Hide resolved
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@embark-studios.com>
@stefanprodan
Copy link
Member

@jahrlin the insecureSkipVerify should be in the MetricsProvider API only, you've added to the Canary API too, please remove it. Also update the CRD manifests accordingly please.

jahrlin added 2 commits June 15, 2021 17:21
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@embark-studios.com>
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@embark-studios.com>
@stefanprodan stefanprodan changed the title add option for insecureSkipVerify for Prometheus and Graphite Add insecureSkipVerify option for Prometheus and Graphite Jun 15, 2021
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Jun 15, 2021
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@embark-studios.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jahrlin 🎖️

@stefanprodan stefanprodan merged commit 0dc6f33 into fluxcd:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants