Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra podLabels options to Flagger Helm Chart #966

Conversation

eduardobarbosa
Copy link
Contributor

This allows add extra pod labels to Flagger helm chart.

Signed-off-by: eduardobarbosa <eduardobarbosadacosta@gmail.com>
@eduardobarbosa eduardobarbosa force-pushed the eduardobarbosa/add-podlabels-helmchart branch from 8fc27c4 to 3811470 Compare August 4, 2021 18:10
@maruina
Copy link

maruina commented Aug 18, 2021

+1 for this one. If you have flagger and the loadtester in the Istio mesh, this allows you to add the required flags to properly label the traffic (otherwise the source_app is unknown)

@codecov-commenter
Copy link

Codecov Report

Merging #966 (3811470) into main (e2b08eb) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   56.88%   56.91%   +0.03%     
==========================================
  Files          71       71              
  Lines        5861     5861              
==========================================
+ Hits         3334     3336       +2     
+ Misses       2032     2030       -2     
  Partials      495      495              
Impacted Files Coverage Δ
pkg/canary/config_tracker.go 84.30% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b08eb...3811470. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @eduardobarbosa

@stefanprodan stefanprodan merged commit 04ec7f0 into fluxcd:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants