Merge pull request #2782 from 2opremio/clarify-cached-errors

Distinguish cached registry errors from live ones
fluxcd · Jan 23, 2020 · 5cec301 · 5cec301
2 parents 1516b06 + ce21305
commit 5cec301
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/registry/cache/registry.go b/pkg/registry/cache/registry.go
@@ -2,6 +2,7 @@ package cache
 
 import (
 	"encoding/json"
+	"fmt"
 	"time"
 
 	"github.com/pkg/errors"
@@ -90,7 +91,7 @@ func (c *Cache) GetImageRepositoryMetadata(id image.Name) (image.RepositoryMetad
 	// updated the result.
 	if repo.LastUpdate.IsZero() {
 		if repo.LastError != "" {
-			return image.RepositoryMetadata{}, errors.New(repo.LastError)
+			return image.RepositoryMetadata{}, fmt.Errorf("item not in cache, last error: %s", repo.LastError)
 		}
 		return image.RepositoryMetadata{}, ErrNotCached
 	}