Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fix ineffective break statement #1439

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Fix ineffective break statement #1439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions integrations/helm/chartsync/chartsync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ func New(logger log.Logger, polling Polling, clients Clients, release *release.R
}
}

// Run creates a syncing loop monitoring repo chart changes. It is
// assumed that the *git.Repo given to the config is ready to use
// before this is invoked.
// Run creates a syncing loop monitoring repo chart changes. It is
// assumed that the *git.Repo given to the config is ready to use
// before this is invoked.
//
// The behaviour if the git mirror becomes unavailable while it's
// running is not defined (this could be tightened up).
Expand Down Expand Up @@ -174,7 +174,7 @@ func (chs *ChartChangeSync) Run(stopCh <-chan struct{}, errc chan error, wg *syn

case <-stopCh:
chs.logger.Log("stopping", "true")
break
return
}
}
}()
Expand Down