This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Give full output of git command on errors #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
more-feedback-on-git-errors
branch
from
92734c1
to
9f0ad02
Compare
2opremio
changed the title
2opremio
force-pushed
the
more-feedback-on-git-errors
branch
from
9f0ad02
to
498954e
Compare
I restricted the error message to the first line of output deliberately. But who knows where that impulse came from, it was a while ago. It's certainly useful to have the full error from git.
Because they will be interleaved? |
Yep |
2opremio
force-pushed
the
more-feedback-on-git-errors
branch
5 times, most recently
from
7524f8c
to
f1f1e81
Compare
|
@squaremo I have finally finished fixing the race conditions PTAL |
squaremo
reviewed
May 16, 2019
As a side effect, the tracing of commands also prints the full output (instead of separating stderr and stdout), which I think is more useful.
2opremio
force-pushed
the
more-feedback-on-git-errors
branch
from
f1f1e81
to
d90ec58
Compare
Re-examining this: why do we care that they are interleaved? Any particular interleaving would be a coincidence anyway, and it's more useful to know which of stderr or stdout any particular output went to. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect, the tracing of commands also prints the full output (instead of separating stderr and stdout), which I think is more useful.
Implementing this was triggered by #2050 (
git clonewas failing due toknown_hostsbeing updated, but I had to exec into the pod in order to figure it out).