This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding an explicit warning to users that Flux ignores JSON files.
If we are unable to match the image of the workload to a tag from our cache, we still list the name of the tag and a question mark where we would normally list the created date, to indicate we have no record of it in our cache.
Before this change the `fluxctl list-workloads` command would only list the status of a workload if it had containers. But because of how we integrated HelmReleases into the Flux daemon, a HelmRelease only has 'containers' if we are able to detect images in the .spec.values of the resource. After this change it will always list the status of the workload (and any policies), regardless of the amount of containers it (does not) have.
We log when a resource in a manifest is dropped from sync because it's marked as ignored; would also help troubleshooting if we log when a resource is dropped because it's not in the allowed namespaces.
Logging all excluded resources may be quite noisy. Instead, collect the IDs of excluded resources and log once (or no times, if there aren't any).
Should resolve the trigger of several CVE warnings (which did not pose a threat): CVE-2019-3829, CVE-2019-3836, CVE-2018-1000654
Leftover from #1777
As a side effect, the tracing of commands also prints the full output (instead of separating stderr and stdout), which I think is more useful.
In order for the initialization to retry if there is a netwroking glitch
Using master broke connectivity with the external world (at least when used CircleCI)
* Run sequentially after build and tests in CircleCI to reuse artifacts * Support running it locally (both in Linux and Darwin systems) through `make e2e`. An existing Kubernetes cluster will be used if available, otherwise a cluster will be created with Kind.
hiddeco
approved these changes
May 22, 2019
squaremo
reviewed
May 22, 2019
squaremo
approved these changes
May 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for compiling this Fons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.