This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Support both new fluxcd and original annotations #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
approved these changes
Jul 5, 2019
hiddeco
force-pushed
the
decouple/annotation-domain
branch
from
4d5d195 to
1f0162f
Compare
The new prefix for annotations is `fluxcd.io`; but, many files will use `flux.weave.works`, and we don't want to suddenly not understand the policies in those. This commit adds support for interpreting and updating policies as annotations with either prefix. When updating, if an annotation uses the old prefix, that will be retained; otherwise, the new prefix is used.
hiddeco
force-pushed
the
decouple/annotation-domain
branch
from
1f0162f to
cc7c63f
Compare
|
Getting this in to finish #2249 with the new annotation domain (and to support updates of existing annotations). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new prefix for annotations is
fluxcd.io; but, many files willuse
flux.weave.works, and we don't want to suddenly not understandthe policies in those.
This commit adds support for interpreting and updating policies as
annotations with either prefix. When updating, if an annotation uses
the old prefix, that will be retained; otherwise, the new prefix is
used.
This change is backward-compatible, but we may want to keep it back until we're releasing other "decoupling" changes.
Fixes #2217.