-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
Update docs with Kustomize install instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this no longer makes the get started tutorial accessible to completely newcomers, instead I would make this either an extended part of this tutorial as a section or a follow up tutorial in a new document.
I think the opposite. Instead of pulling the whole Flux repo and editing files, now you can just copy/past/run the instructions, way easier and clean in my opinion. |
@stefanprodan agreed, but you no longer understand what happens, just that it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only comments for the minute ..
With respect to whether this is a good way to show people how to install flux for the first time:
|
docs/tutorials/get-started.md
Outdated
``` | ||
|
||
The default sync frequency is 5 minutes. This can be tweaked easily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this was already there or is new, but my thought while reading this was "can be tweaked easily how?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already there. Let's address it in #2298
93e7d1f
to
9f4d520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Stefan 🔥
Add docs with Kustomize install instructions