Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Install docs fixes #2384

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Install docs fixes #2384

merged 1 commit into from
Aug 21, 2019

Conversation

stefanprodan
Copy link
Member

Fix fluxctl install command, replace --git-path with --git-paths.
Fix podinfo example, replace PODINFO_UI_COLOR with PODINFO_UI_MESSAGE.
Fix Kustomize install, add namespace.yaml to resources.

@stefanprodan stefanprodan added the docs Issue or PR relates to documentation label Aug 21, 2019
@stefanprodan stefanprodan requested a review from hiddeco August 21, 2019 16:17
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware that this won't be published to the stable documentation until the next release.

@stefanprodan
Copy link
Member Author

stefanprodan commented Aug 21, 2019

@hiddeco can we pin the stable to a master commit instead of a tag? The current fluxctl install command is broken 😢

@hiddeco
Copy link
Member

hiddeco commented Aug 21, 2019

@stefanprodan not possible, stable is magic from RTD based on published semver (git) tags.

@stefanprodan stefanprodan merged commit b3288cc into master Aug 21, 2019
@stefanprodan stefanprodan deleted the docs-install-fix branch August 21, 2019 17:39
@stefanprodan
Copy link
Member Author

I would switch back to master then...

@2opremio
Copy link
Contributor

Fix fluxctl install command, replace --git-path with --git-paths.

Oh dear. It sucks that it's inconsistent with fluxd, sorry about that. Since it's already released, should we simply accept both?

@stefanprodan
Copy link
Member Author

@2opremio yes I think accepting both would be best.

@hiddeco hiddeco added this to the 1.14.1 milestone Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issue or PR relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants