Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Tweak logged warning of unsupported resource kind #2471

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Sep 24, 2019

As the previous warning message did not provide enough context to the
user to be able to figure out why it was being marked as 'unsupported'.

Context: https://weave-community.slack.com/archives/C4U5ATZ9S/p1569340270209200

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also log the kind name? e.g. ConfigMap

@hiddeco
Copy link
Member Author

hiddeco commented Sep 24, 2019

@stefanprodan it is included in the resource ID <namespace>:<kind>/<name>.

As the previous warning message did not provide enough context to the
user to be able to figure out why it was being marked as 'unsupported'.
@hiddeco hiddeco merged commit b37e193 into master Sep 25, 2019
@hiddeco hiddeco deleted the misc/kind-not-supported-err branch September 25, 2019 08:08
@hiddeco hiddeco added this to the 1.15.0 milestone Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants