Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add ssh-keygen key format option #2911

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Add ssh-keygen key format option #2911

merged 1 commit into from
Mar 26, 2020

Conversation

alaa
Copy link
Contributor

@alaa alaa commented Mar 14, 2020

Adding an option to specify the format of the generate SSH keys using ssh-keygen utility. This helps users to better integrate and manage flux installation with existing automation tools which are only able to read certain key format.

For example, Terraform TLS provider is not able to read the default OpenSSH RFC4716 format so being able to change the format on the installation to PEM format solves this issue and makes it trackable by the Terraform state natively.

I kept the default format in the values file the same, so basically this will not change the default format which Flux uses at installation time. But only add the ability to pick different formats when needed.

For more information check the -m option in man ssh-keygen

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat and tidy, could not have done it any better. Thanks @alaa 🌷

@hiddeco hiddeco merged commit ac0f9a1 into fluxcd:master Mar 26, 2020
@hiddeco hiddeco added this to the 1.19.0 milestone Mar 26, 2020
@alaa alaa mentioned this pull request Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants