Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Remove support for HelmRelease alpha and beta #2949

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Mar 30, 2020

This PR removes the HelmRelease v1beta1 and v1alpha2 clients from Flux codebase. This means Flux will no longer update container images for:

  • helmreleases.helm.fluxcd.io/v1beta1
  • fluxhelmreleases.helm.integrations.flux.weave.works/v1alpha2

The Helm Operator users who upgraded to helmreleases.helm.fluxcd.io/v1 will not be impacted by this change.

Fix: #2945

@stefanprodan stefanprodan requested a review from hiddeco March 30, 2020 11:38
@stefanprodan stefanprodan added this to the 1.19.0 milestone Mar 30, 2020
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

We still try to unmarshal the FluxHelmRelease kind in resource.go:216. There also is a in-comment reference left in patch.go:112.

@stefanprodan
Copy link
Member Author

@hiddeco I removed the last traces of FluxHelmRelease.

@stefanprodan stefanprodan merged commit f5e7546 into master Mar 30, 2020
@stefanprodan stefanprodan deleted the remove-beta-hr branch March 30, 2020 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for HelmRelease v1beta1 and v1alpha2
2 participants