Fix NaN Cluster Stats Dashboard #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
darkowlzz
reviewed
Jan 11, 2024
| "exemplar": true, | ||
| "expr": "sum(rate(gotk_reconcile_duration_seconds_sum{namespace=~\"$operator_namespace\",exported_namespace=~\"$namespace\",kind=~\"GitRepository|HelmRepository|Bucket|OCIRepository\"}[5m])) by (kind)\n/\n sum(rate(gotk_reconcile_duration_seconds_count{namespace=~\"$operator_namespace\",exported_namespace=~\"$namespace\",kind=~\"GitRepository|HelmRepository|Bucket|OCIRepository\"}[5m])) by (kind)", | ||
| "expr": "sum(rate(gotk_reconcile_duration_seconds_sum{namespace=~\"$operator_namespace\",exported_namespace=~\"$namespace\",kind=~\"GitRepository|HelmRepository|Bucket|OCIRepository\"}[5m])) by (kind)\n/\n sum(rate(gotk_reconcile_duration_seconds_count{namespace=~\"$operator_namespace\",exported_namespace=~\"$namespace\",kind=~\"GitRepository|HelmRepository|Bucket|OCIRepository\"}[5m])>0) by (kind)", |
There was a problem hiding this comment.
Shouldn't the "Cluster reconciliation duration" and "Source acquisition duration" panels below also be updated likewise?
| @@ -358,21 +366,30 @@ | |||
| "text": {}, | |||
| "valueMode": "color" | |||
| }, | |||
| "pluginVersion": "10.0.3", | |||
| "pluginVersion": "10.2.2", | |||
There was a problem hiding this comment.
I also updated to the latest Grafana format by 10.2.x.
Wouldn't such grafana format updates apply to the other dashboards too? It may be better to update all the dashboards together separately and keep this PR more focused to fixing the bug.
|
Hey @mjtrangoni have you seen the comments from @darkowlzz Can you separate out the plugin version update, or is it dependent for some reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @darkowlzz,
related to #22, I gave it a try it seems to work as expected. JFTR, I also updated to the latest Grafana format by
10.2.x.Thank you