-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC-0003] Add commands for managing OCI artifacts #2856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
stefanprodan
changed the title
Add commands for managing OCI artifacts
[POC] Add commands for managing OCI artifacts
Jun 21, 2022
stefanprodan
force-pushed
the
oci
branch
4 times, most recently
from
June 22, 2022 10:16
f855a04
to
1ace162
Compare
souleb
reviewed
Jun 22, 2022
kingdonb
pushed a commit
to kingdonb/tailscale-k8s
that referenced
this pull request
Jun 22, 2022
https://cloud-native.slack.com/archives/C02JQ9GLP26/p1655891456182639 fluxcd/flux2#2856 fluxcd/source-controller#788 fluxcd/kustomize-controller#684 Signed-off-by: Kingdon Barrett <kingdon@weave.works>
stefanprodan
force-pushed
the
oci
branch
3 times, most recently
from
July 7, 2022 13:50
11a860b
to
45abb12
Compare
stefanprodan
changed the title
[POC] Add commands for managing OCI artifacts
[RFC-0003] Add commands for managing OCI artifacts
Jul 8, 2022
stefanprodan
force-pushed
the
oci
branch
4 times, most recently
from
July 8, 2022 14:46
60129ec
to
0957710
Compare
hiddeco
reviewed
Jul 11, 2022
This was referenced Aug 2, 2022
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Fixup docs string to match pull command Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
kingdonb
reviewed
Aug 9, 2022
kingdonb
reviewed
Aug 9, 2022
kingdonb
reviewed
Aug 9, 2022
kingdonb
reviewed
Aug 9, 2022
kingdonb
reviewed
Aug 9, 2022
darkowlzz
reviewed
Aug 9, 2022
darkowlzz
reviewed
Aug 9, 2022
Co-authored-by: Kingdon Barrett <kingdon@weave.works> Co-authored-by: Sunny <darkowlzz@protonmail.com> Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
* Added support for OCIRepositories to `flux trace` * Changed indentation to compensate new, longer field name "Source Revision" * Added unit tests for the new output closes #2970 Signed-off-by: Max Jonas Werner <max@e13.dev>
Make `flux trace` work with OCIRepository
darkowlzz
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds commands to the Flux CLI for managing OCI artifacts as described in the RFC Flux OCI support for Kubernetes manifests.
OCI artifact commands
For authentication purposes, all
flux <verb> artifact
commands are using the~/.docker/config.json
config file and the Docker credential helpers.The artifacts create with
flux push artifact
are annotated with the standard OCI annotation keys:org.opencontainers.image.source
org.opencontainers.image.revision
org.opencontainers.image.created
OCI repository commands