-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flux events
command
#3628
Add flux events
command
#3628
Conversation
baf15f2
to
b02187f
Compare
I have a local copy of this now and will try it out for a couple days 👍 |
765893b
to
03e1fd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @somtochiama and @hiddeco
951071d
to
f99f5d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some tidying to improve UX and solved an issue with the routines which caused the process to hang on certain systems with very fast CPUs.
Also tried to improve the way kinds are mapped, but I think it would be better in the future to separate GVK mapping from relational stuff by using the core Kubernetes packages which are available for this, as this would also allow to resolve short hands, etc. Plus reduce the maintenance effort of things that do not have other "relational" stuff attached to them.
See my individual commits to get a better idea of this.
However, this seems to work decent enough for initial introduction for now. Thank you @somtochiama. 🙇
This adds a command to Flux which behaves similarly as `kubectl events`, including the Flux sources events when showing events for top level objects, thus making debugging easy for Flux users. For example, `flux events --for kustomization/<name>` includes the events of its source (e.g. a `GitRepository`, `OCIRepository` or `Bucket`). In addition, `flux events --for helmrelease/<name>` includes events of the `HelmChart` and `HelmRepository`. While `flux events --for alerts/<name>` includes the events of the `Provider`. Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
This pull request closes #3618
Filter by resource