Refactor flux uninstall command #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
enhancement
stefanprodan
force-pushed
the
refac-uninstall
branch
from
64ff9e7 to
b9ef9f9
Compare
hiddeco
reviewed
Feb 9, 2021
hiddeco
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Awesome job @stefanprodan 💯 🥇
One tiny nit on the (already existing) description of the --dry-run flag, otherwise LGTM 👍
stefanprodan
force-pushed
the
refac-uninstall
branch
2 times, most recently
from
01a541e to
b975014
Compare
|
This should be merged right before flux2 v0.8 release, to avoid confusion around uninstall docs. |
This was referenced Feb 10, 2021
stefanprodan
force-pushed
the
refac-uninstall
branch
3 times, most recently
from
a0a819d to
caff61f
Compare
- deletes Flux components (deployments and services) - deletes Flux RBAC (service accounts, cluster roles and cluster role bindings) - removes the Kubernetes finalizers from Flux custom resources - deletes Flux custom resource definitions and custom resources - deletes the namespace where Flux was installed - preserves the Kubernetes objects and Helm releases that were reconciled on the cluster by Flux Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
refac-uninstall
branch
from
caff61f to
0f1d27f
Compare
ybelleguic
pushed a commit
to ybelleguic/flux2
that referenced
this pull request
Jan 9, 2023
CI: Set Public ECR region to us-east-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of
flux uninstallin Go without any shell-execs to kubectl.The uninstall command performs the following operations:
--keep-namespace=falseBreaking changes:
uninstallcommand will no longer remove any Kubernetes objects or Helm releases that were reconciled on the cluster by Fluxcrdsandresourcesarguments were removedExample:
Fix: #811
Fix: #632