You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this discussion it was reported that the Flux CLI fails to bootstrap a Bitbucket Server/Stash repository. The reason is that no logger is passed to the client but a logger is required for the client to work. This, in conjunction with this change in logr led to the bug experienced in the Flux CLI.
It should be up to the consumer of the GGP API whether to pass in a logger or not so it should be made truly optional.
In version 1.2.4 a [change](go-logr/logr#166)
was introduced that significantly changed the assumptions about logr's
API, i.e. that `logr.Logger{} != logr.Discard()`. This condition
doesn't evaluate to true with 1.2.4, anymore, and the default value of
the `logr.Logger` type is now usable as a replacement for
`logr.Discard()`.
Therefore we do not need to check if the value has been provided,
anymore: If it is not provided, the default one is used which is
effectively a discarding logger.
closes#209
Signed-off-by: Max Jonas Werner <mail@makk.es>
In this discussion it was reported that the Flux CLI fails to bootstrap a Bitbucket Server/Stash repository. The reason is that no logger is passed to the client but a logger is required for the client to work. This, in conjunction with this change in logr led to the bug experienced in the Flux CLI.
It should be up to the consumer of the GGP API whether to pass in a logger or not so it should be made truly optional.
related to fluxcd/flux2#3808
The text was updated successfully, but these errors were encountered: