Patch CRDs with origin labels #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the applied CRDs to be traced using the same labels as currently applied to resources using a Kustomize post-render. Kustomize is not used here as the apply logic for CRDs is different from the approach used during releasing, where we inject the labels in such a way that they are written back to the Helm storage in the rendered manifest. This to match Helm's logic from which our present code is already derived (buth with support for policies). This also moves the full responsibility of dealing with the install of CRDs to ourselves, as we no longer fall back to Helm's logic when `Create` is configured as a policy during a Helm install. As this would not allow us to add the labels. Signed-off-by: Hidde Beydals <hello@hidde.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the applied CRDs to be traced using the same labels as currently applied to resources using a Kustomize post-render.
Kustomize is not used here as the apply logic for CRDs is different from the approach used during releasing, where we inject the labels in such a way that they are written back to the Helm storage in the rendered manifest. This to match Helm's logic from which our present code is already derived (buth with support for policies).
This also moves the full responsibility of dealing with the install of CRDs to ourselves, as we no longer fall back to Helm's logic when
Createis configured as a policy during a Helm install. As this would not allow us to add the labels.Fixes #476