Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Release condition gauge (instead of phase gauge) #403

Merged
merged 2 commits into from
May 11, 2020
Merged

Release condition gauge (instead of phase gauge) #403

merged 2 commits into from
May 11, 2020

Conversation

seaneagan
Copy link
Contributor

Fixes #395

@seaneagan seaneagan changed the title Release Condition gauge Release condition gauge (instead of phase gauge) May 4, 2020
@seaneagan seaneagan force-pushed the condition_gauge branch 5 times, most recently from aa13b68 to 5bda168 Compare May 5, 2020 19:43
hiddeco
hiddeco approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have definitely been on 🔥 while I was enjoying time off. This looks indeed like a better alternative to me than the previous solution. 🌷

@seaneagan @hiddeco
Revert "Expose HelmRelease phases as a Prometheus gauge"
728b8dc 
This reverts commit dfe842a.

See fluxcd#383, the intention is to replace this with a condition
based gauge in the future.
@seaneagan @hiddeco
metrics: Add condition gauge
aaae029 
Fixes fluxcd#395
@hiddeco hiddeco merged commit 5f9e440 into fluxcd:master May 11, 2020
@seaneagan seaneagan deleted the condition_gauge branch May 11, 2020 15:19
@hiddeco hiddeco added this to the 1.1.0 milestone May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Release condition gauge (instead of phase gauge)
2 participants
@seaneagan @hiddeco