Update ImageUpdateAutomation Status with Patch. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the functionality when updating the status to use Patch rather than Updating, which is more resilient to changes. Signed-off-by: Kevin McDermott <bigkevmcd@gmail.com>
bigkevmcd
force-pushed
the
patch-status-fix
branch
from
867b50b
to
0961617
Compare
stefanprodan
approved these changes
Mar 22, 2021
squaremo
reviewed
Mar 22, 2021
| newStatus imagev1.ImageUpdateAutomationStatus) error { | ||
|
|
||
| var auto imagev1.ImageUpdateAutomation | ||
| if err := r.Get(ctx, req.NamespacedName, &auto); err != nil { |
There was a problem hiding this comment.
This can set the status of a different version of the object than the one we're reconciling. For that reason, I think this is a fragile fix, even if it doesn't cause other problems.
|
I would like to have at least seen a test before this was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the functionality when updating the status to use Patch
rather than Update, which is more resilient to changes.
Fix: #131