Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image name marker #162

Merged
merged 2 commits into from
May 6, 2021
Merged

Fix image name marker #162

merged 2 commits into from
May 6, 2021

Conversation

relu
Copy link
Member

@relu relu commented May 6, 2021

The image name was incorrectly extracted from the given reference,
yielding a trimmed version of the string and breaking the resulting
replacement value.

For example, if the policy latest image was: ghcr.io/stefanprodan/podinfo:5.2.0
It would yield: ghcr.i.

relu added 2 commits May 6, 2021 14:03
Upgraded kyaml to v0.10.19

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
The image name was incorrectly extracted from the given reference,
yielding a trimmed version of the string and breaking the resulting
replacement value.

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu relu added the bug Something isn't working label May 6, 2021
@relu relu requested review from squaremo and stefanprodan and removed request for squaremo May 6, 2021 12:45
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @relu 🏅

@stefanprodan stefanprodan merged commit 473e003 into main May 6, 2021
@stefanprodan stefanprodan deleted the fix-image-name-marker branch May 6, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants