controllers: use new git contract
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
sc-git-update
branch
3 times, most recently
from
34ed85a to
f03cb7b
Compare
darkowlzz
reviewed
Oct 27, 2021
hiddeco
force-pushed
the
sc-git-update
branch
2 times, most recently
from
eef0f29 to
581b3fe
Compare
This commit makes use of the refactored `git` package, which has been reworked to increase stability and test coverage, and ensures implementation details do not leak out into the "main wrapper". This indirectly seems to resolve a memory leak that happenedd with the previous wiring, thereby fixing #247. The code changes for this controller itself are minimal, mostly ensuring the auth and checkout configurations are created in the "new way". Signed-off-by: Hidde Beydals <hello@hidde.co>
This supersedes #238. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
sc-git-update
branch
from
581b3fe to
b29b87a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the refactored
gitpackage, which hasbeen reworked to increase stability and test coverage, and ensures
implementation details do not leak out into the "main wrapper".
This indirectly seems to resolve a memory leak that happenedd with
the previous wiring, and thereby fixes #247.
The code changes for this controller itself are minimal, mostly
ensuring the auth and checkout configurations are created in the
"new way".
In addition, it ensures all underlying
libgit2C objects areproperly
Freed, replacing #238.