Remove libgit2 and git2go from codebase #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 9, 2022 11:27
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
hiddeco
reviewed
Dec 9, 2022
There was a problem hiding this comment.
🙌 awesome work coming together @pjbgf (& @aryan9600)
Two tiny nits.
Comment on lines
114
to
115
| The [`gitImplementation` field][source-docs] in the referenced `GitRepository` is now ignored. All | ||
| reconciliations are now executed using the `go-git` implementation. |
There was a problem hiding this comment.
Suggested change
| The [`gitImplementation` field][source-docs] in the referenced `GitRepository` is now ignored. All | |
| reconciliations are now executed using the `go-git` implementation. | |
| The [`gitImplementation` field][source-docs] in the referenced `GitRepository` is ignored. All | |
| reconciliations are executed using the `go-git` implementation. |
|
|
||
| # Some dependencies have to installed | ||
| # for the target platform: https://github.com/tonistiigi/xx#go--cgo | ||
| RUN xx-apk add musl-dev gcc |
There was a problem hiding this comment.
Ref recommends explicit declaration of CGO_ENABLED.
In addition: might be worth taking note of a brief "why" for the CGO dependency.
|
Successfully tested the rc image against:
|
added 3 commits
December 9, 2022 13:43
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
libgit2implementation which was deprecated in v0.27.0,resulting in a smaller code base and more streamlined build process.
Test image:
ghcr.io/fluxcd/image-automation-controller:rc-95ace68b.Things of note:
Breaking changes:
ForceGoGitImplementationhas been deprecated and removed.