Merge pull request #535 from kingdonb/patch-finalizers

Use patch instead of update when adding finalizers
fluxcd · Jan 14, 2022 · b18584a · b18584a
2 parents 4e8fd15 + 441b48a
commit b18584a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/controllers/kustomization_controller.go b/controllers/kustomization_controller.go
@@ -152,8 +152,9 @@ func (r *KustomizationReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 
 	// Add our finalizer if it does not exist
 	if !controllerutil.ContainsFinalizer(&kustomization, kustomizev1.KustomizationFinalizer) {
+		patch := client.MergeFrom(kustomization.DeepCopy())
 		controllerutil.AddFinalizer(&kustomization, kustomizev1.KustomizationFinalizer)
-		if err := r.Update(ctx, &kustomization); err != nil {
+		if err := r.Patch(ctx, &kustomization, patch); err != nil {
 			log.Error(err, "unable to register finalizer")
 			return ctrl.Result{}, err
 		}