Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drift detection in Secrets and ConfigMaps #451

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Conversation

stefanprodan
Copy link
Member

This PR updates the fluxcd/pkg/ssa package to v0.0.5 with the following improvements:

  • remove creationTimestamp metadata before apply (this field is read-only and should not be in Git)
  • improve Secrets drift detection by comparing the data and stringData fields
  • improve ConfigMap drift detection by comparing the data and binaryData fields

This PR contains a test for confirming that SOPS encrypted secrets no longer generate change events on each reconciliation.

Fix: #450

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 57c6302 into main Oct 11, 2021
@stefanprodan stefanprodan deleted the ssa-fix-diff branch October 11, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from v0.17.2 to v0.18.0 causes changes on each reconcile cycle
2 participants