sops: ensure proper wiring to default server #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
force-pushed
the
fix-sops-decrypt-defaultserver
branch
from
e1f8d5d
to
6d6e4a9
Compare
But we don't encrypt anything |
|
That does not really matter, as the intent of the full implementation is that it should work anyway for e.g. potential further integration in the Flux CLI (or something). This is technically a bug, and is right to be addressed :-). |
hiddeco
approved these changes
Dec 9, 2021
hiddeco
changed the title
hiddeco
changed the title
|
@souleb the commit takes care of encryption but mentions "decryption". |
hiddeco
changed the title
Signed-off-by: Soule BA <bah.soule@gmail.com>
souleb
force-pushed
the
fix-sops-decrypt-defaultserver
branch
from
6d6e4a9
to
3191f49
Compare
|
@hiddeco sorry 🙏 , I have rewritten the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure we use the right service to encrypt.