Add kubeconfig flags #593
Merged
Add kubeconfig flags #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Mar 29, 2022
@stefanprodan Added a new commit to this effect. PTAL |
|
@pjbgf looks like the Makefile changes don't work, sops is not added to the PATH. |
pjbgf
force-pushed
the
new-kube-flag
branch
2 times, most recently
from
5217052
to
508b4d6
Compare
|
@stefanprodan they have been fixed now, PTAL |
|
@pjbgf please port this to helm-controller so we can bundle them in the same flux release. |
stefanprodan
requested changes
Apr 1, 2022
added 3 commits
April 1, 2022 10:11
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Some tests requires the sops CLI to be installed, by adding it as a requirement of the Makefile tests target we make it easier for new contributors to engage with the codebase. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Two new flags were added to allow users to enable the use of user.Exec and InsecureTLS in the kubeconfigs provided remote apply reconciliations. Breaking change: both functionalities are no longer enabled by default. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
stefanprodan
approved these changes
Apr 1, 2022
stefanprodan
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new flags were added to allow users to enable the use of user.Exec (
--insecure-kubeconfig-exec) and InsecureTLS (insecure-kubeconfig-tls) in the kubeconfigs provided for remote apply.Breaking change: both functionalities are no longer enabled by default.