Retry downloading artifacts on not found errors #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
changed the title
stefanprodan
force-pushed
the
artifact-downloader
branch
2 times, most recently
from
9be2083
to
88a2e47
Compare
hiddeco
reviewed
Jun 30, 2022
hiddeco
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Other than the naming nit, this seems to be doing what is described. Thanks @stefanprodan 🥇
stefanprodan
force-pushed
the
artifact-downloader
branch
from
88a2e47
to
9ad24d6
Compare
- Extract the artifact operations such as download, verify, untar into a dedicated struct - Introduce a dedicated type for artifact not found errors - On artifact not found errors, log the error, update the ready status message and requeue the object - Retry the artifact download at the interval set with `--requeue-dependency` (defaults to 30s) Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
artifact-downloader
branch
from
9ad24d6
to
cfd5200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--requeue-dependency(defaults to 30s)This PR gracefully handles Flux upgrades, where instead of erroring out while source-controller rebuilds the artifacts cache, kustomize-contoller retries the fetch operations. Ref: fluxcd/flux2#2884