fix: Retry when artifacts are available in storage #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
bug
hiddeco
approved these changes
Oct 5, 2023
|
Successfully created backport PR for |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a Flux upgrade, when SC storage is wiped, SC will remove the
.status.artifactfrom sources before it tries to fetch from upstream. Due to this change in SC behaviour, the retry logic of the artifact fetcher in KC no longer works as there is no.status.artifact.urlto retry for. This PR allows for faster recovery, once the artifact is available in storage, even if the revision is the same, KC will reconcile on the spot instead of waiting for the dependency retry interval.