Merge pull request #603 from GJKrupa/main

Remove checks for empty user and channel parameters in Rocket notifier

internal/notifier/rocket.go

@@ -19,7 +19,6 @@ package notifier
 import (
 	"context"
 	"crypto/x509"
-	"errors"
 	"fmt"
 	"net/url"
 	"strings"
@@ -43,14 +42,6 @@ func NewRocket(hookURL string, proxyURL string, certPool *x509.CertPool, usernam
 		return nil, fmt.Errorf("invalid Rocket hook URL %s: '%w'", hookURL, err)
 	}
 
-	if username == "" {
-		return nil, errors.New("empty Rocket username")
-	}
-
-	if channel == "" {
-		return nil, errors.New("empty Rocket channel")
-	}
-
 	return &Rocket{
 		Channel:  channel,
 		URL:      hookURL,

internal/notifier/rocket_test.go

@@ -46,3 +46,23 @@ func TestRocket_Post(t *testing.T) {
 	err = rocket.Post(context.TODO(), testEvent())
 	require.NoError(t, err)
 }
+
+func TestRocket_PostWithoutChannelOrUser(t *testing.T) {
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		b, err := io.ReadAll(r.Body)
+		require.NoError(t, err)
+
+		var payload = SlackPayload{}
+		err = json.Unmarshal(b, &payload)
+		require.NoError(t, err)
+		require.Equal(t, "gitrepository/webapp.gitops-system", payload.Attachments[0].AuthorName)
+		require.Equal(t, "metadata", payload.Attachments[0].Fields[0].Value)
+	}))
+	defer ts.Close()
+
+	rocket, err := NewRocket(ts.URL, "", nil, "", "")
+	require.NoError(t, err)
+
+	err = rocket.Post(context.TODO(), testEvent())
+	require.NoError(t, err)
+}