Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fuzz testing for notifiers #306

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Add fuzz testing for notifiers #306

merged 1 commit into from
Jan 12, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Jan 12, 2022

Following-up from the security audit, I reviewed the initial Fuzz PR and created this PR that supersedes it.

Main changes:

  • Create fuzzers for all notifiers that required no code change to support fuzzing.
  • Structure the fuzz implementation to be closer to what fuzz testing might look like once golang 1.18 built-in fuzz feature is released.
  • Add Makefile target to enable smoke testing fuzzers locally.
  • Add github workflow to test and upload crash results.

Add fuzz testing for notifiers
4f111d2 
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf mentioned this pull request Jan 12, 2022
Closed
@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Jan 12, 2022
stefanprodan
stefanprodan approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

@stefanprodan stefanprodan merged commit 2a728b0 into fluxcd:main Jan 12, 2022
@stefanprodan stefanprodan mentioned this pull request Jan 12, 2022
Closed
@pjbgf pjbgf deleted the fuzz branch January 12, 2022 11:47
@stefanprodan stefanprodan mentioned this pull request Jan 19, 2022
Closed
24 tasks
@pjbgf pjbgf mentioned this pull request Feb 16, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjbgf @stefanprodan