Add .spec.interval in v1beta3 Provider #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
added
area/alerting
1 task
hiddeco
approved these changes
Dec 12, 2023
darkowlzz
force-pushed
the
v1beta3-provider-interval
branch
from
bbe6831
to
d8266d7
Compare
For backwards compatibility with v1beta2 Provider, add .spec.interval with deprecation marker. Interval was an optional field in v1beta2 with internal default. Only the users who had explicitly set intervals would have encountered this incompatibility error after upgrade. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
v1beta3-provider-interval
branch
from
d8266d7
to
7f5eea0
Compare
stefanprodan
approved these changes
Dec 13, 2023
stefanprodan
added
the
backport:release/v1.2.x
|
Successfully created backport PR for |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backwards compatibility with v1beta2 Provider, add .spec.interval with deprecation marker.
Interval was an optional field in v1beta2 with internal default. Only the users who had explicitly set intervals would have encountered this incompatibility error after upgrade.
Fixes fluxcd/flux2#4471.