Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssa: Force apply on invalid and conflict errors #192

Merged
merged 1 commit into from
Dec 4, 2021
Merged

ssa: Force apply on invalid and conflict errors #192

merged 1 commit into from
Dec 4, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan added bug Something isn't working area/server-side-apply SSA related issues and pull requests labels Dec 3, 2021
@stefanprodan stefanprodan changed the title Force apply for invalid and conflict errors ssa: Force apply for invalid and conflict errors Dec 3, 2021
@stefanprodan
Force apply for invalid and conflict errors
0c386be 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan changed the title ssa: Force apply for invalid and conflict errors ssa: Force apply on invalid and conflict errors Dec 3, 2021
hiddeco
hiddeco reviewed Dec 3, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for adding the reference.

@stefanprodan
Copy link
Member Author

I have some doubts that kubectl apply --force is doing the right thing when using webhooks. Assuming you have some validation controller that marks all objects as invalid due to some bug, using force will wipe clean the cluster even if there is no conflict around immutability.

@stefanprodan stefanprodan merged commit 283cbad into main Dec 4, 2021
@stefanprodan stefanprodan deleted the ssa-force-fix branch December 4, 2021 09:18
@stefanprodan stefanprodan mentioned this pull request Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/server-side-apply SSA related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco