oci/auth: Fix aws login with aws-sdk-go-v2 #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
oci-auth-aws-fix
branch
2 times, most recently
from
8856b2f
to
3bb4cd4
Compare
pjbgf
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
LGTM
Thanks for the thread safety improvements @darkowlzz! 🙇
As per aws-sdk-go-v2 docs, new config for creating a session should use config.LoadDefaultConfig() and account ID is not needed for ECR authorization token. In order to maintain the auth API which is shared with other provider, return an empty client for NewClient(). The login implementation loads the default config if the client config is nil. A test can stub the client config before calling login. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
oci-auth-aws-fix
branch
from
3bb4cd4
to
0e7a168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of 750df67 , upgrade to aws-sdk-go-v2.
Without this change, the login fails with error:
As per aws-sdk-go-v2 migration docs, new config for creating a session should use
config.LoadDefaultConfig()and account ID is not needed for ECR authorization token.In order to maintain the auth API compatibility, which is shared with other provider, return an empty client for
NewClient(). The login implementation loads the default config if the client config is nil. A test can stub the client config before calling login.Tested this against EKS using the integration tests with the EKS terraform module fix from fluxcd/test-infra#2.