runtime/conditions: Add HasAny() for conditions and WithT for checker #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
added
the
area/runtime
stefanprodan
approved these changes
Feb 2, 2023
hiddeco
approved these changes
Feb 7, 2023
Use *gomega.WithT in condition checker to be able to assert and fail like a proper go test and as a test helper instead of abrupt exit. Signed-off-by: Sunny <darkowlzz@protonmail.com>
HasAny() helps check if an object contains any of the given list of conditons. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
checker-with-t
branch
from
c0395ef
to
4a3f0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
*gomega.WithTin condition checker to be able to assert and faillike a proper go test and as a test helper instead of abrupt exit.
Also, show the full observed conditions when the conditions checker fails
to be able to evaluate the failure with full context.
Conditions
HasAny()helps check if an object contains any of the given list ofconditons. This is needed in source-controller fluxcd/source-controller#1016.