Update dependencies to Kubernetes 1.30 and adapt to breaking changes #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
requested review from
aryan9600,
hiddeco,
darkowlzz and
a team
as code owners
souleb
approved these changes
Apr 18, 2024
stefanprodan
force-pushed
the
kubernetes-1.30
branch
from
626b7e3
to
fd5aad9
Compare
stefanprodan
changed the title
stefanprodan
force-pushed
the
kubernetes-1.30
branch
from
fd5aad9
to
0d3b369
Compare
This was referenced Apr 18, 2024
stefanprodan
force-pushed
the
kubernetes-1.30
branch
2 times, most recently
from
b4a7345
to
c274055
Compare
Pin controller-runtime to main branch due to breaking change in Kubernetes 1.30 `client-go/tools/leaderelection`. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
kubernetes-1.30
branch
from
2ed79d3
to
067300c
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
kubernetes-1.30
branch
from
067300c
to
52c1fc5
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leaderelection.SwitchMetricwas renamed toleaderelection.LeaderMetricand this breaks controller-runtime. So we have to pin controller-runtime to an unreleased version that contains kubernetes-sigs/controller-runtime#2693 here and in every Flux controller.PS. The breaking change was addressed in https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.0
We can't release Flux v2.3 without bumping Kubernetes to 1.30 and be stuck on 1.29 till end of Q3. I think we should go forward with this, when controller-runtime has a stable release that includes client-go 1.30, we'll do a patch release for Flux v2.3.
PS. Using
major.minorfor the Go version in go.mod is no longer possible because Kubernetes switched to full semver.