tests: Use proper timeouts in gitrepository and helmrepository tests

I assume using "interval" for timeouts was an accident and "timeout" was actually meant to be used. This also fixes flakiness of tests.
fluxcd · Apr 25, 2022 · c2f3664 · c2f3664
1 parent eb0feb0
commit c2f3664
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/controllers/gitrepository_controller_test.go b/controllers/gitrepository_controller_test.go
@@ -434,7 +434,7 @@ func TestGitRepositoryReconciler_reconcileSource_authStrategy(t *testing.T) {
 			},
 			Spec: sourcev1.GitRepositorySpec{
 				Interval: metav1.Duration{Duration: interval},
-				Timeout:  &metav1.Duration{Duration: interval},
+				Timeout:  &metav1.Duration{Duration: timeout},
 			},
 		}
 
@@ -653,7 +653,7 @@ func TestGitRepositoryReconciler_reconcileSource_checkoutStrategy(t *testing.T)
 				},
 				Spec: sourcev1.GitRepositorySpec{
 					Interval:  metav1.Duration{Duration: interval},
-					Timeout:   &metav1.Duration{Duration: interval},
+					Timeout:   &metav1.Duration{Duration: timeout},
 					URL:       server.HTTPAddress() + repoPath,
 					Reference: tt.reference,
 				},
@@ -1517,7 +1517,7 @@ func TestGitRepositoryReconciler_ConditionsUpdate(t *testing.T) {
 					URL:               server.HTTPAddress() + repoPath,
 					GitImplementation: sourcev1.GoGitImplementation,
 					Interval:          metav1.Duration{Duration: interval},
-					Timeout:           &metav1.Duration{Duration: interval},
+					Timeout:           &metav1.Duration{Duration: timeout},
 				},
 			}
 

diff --git a/controllers/helmrepository_controller_test.go b/controllers/helmrepository_controller_test.go
@@ -440,7 +440,7 @@ func TestHelmRepositoryReconciler_reconcileSource(t *testing.T) {
 			},
 			Spec: sourcev1.HelmRepositorySpec{
 				Interval: metav1.Duration{Duration: interval},
-				Timeout:  &metav1.Duration{Duration: interval},
+				Timeout:  &metav1.Duration{Duration: timeout},
 			},
 		}