Adopt Kubernetes style TLS Secrets #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aryan9600
force-pushed
the
tls-secret
branch
2 times, most recently
from
5bde40e
to
bba3179
Compare
hiddeco
reviewed
Aug 10, 2023
sftim
reviewed
Aug 12, 2023
sftim
reviewed
Aug 12, 2023
sftim
reviewed
Aug 12, 2023
aryan9600
force-pushed
the
tls-secret
branch
3 times, most recently
from
19902cc
to
77a31f4
Compare
darkowlzz
reviewed
Aug 16, 2023
aryan9600
force-pushed
the
tls-secret
branch
3 times, most recently
from
fc31743
to
7857297
Compare
aryan9600
added
enhancement
aryan9600
changed the title
darkowlzz
reviewed
Aug 21, 2023
aryan9600
force-pushed
the
tls-secret
branch
2 times, most recently
from
0dbcd4e
to
185d9ea
Compare
darkowlzz
reviewed
Aug 22, 2023
aryan9600
force-pushed
the
tls-secret
branch
2 times, most recently
from
6384bf3
to
23f6764
Compare
Adopt Kubernetes TLS secrets API to check for TLS data in the Secret referred to by `.spec.certSecretRef`, i.e. check for keys `tls.crt` and `tls.key` for the certificate and private key. Use `ca.crt` for the CA certificate. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Adopt Kubernetes TLS secrets API to check for TLS data in the Secret referred to by `.spec.certSecretRef`, i.e. check for keys `tls.crt` and `tls.key` for the certificate and private key. Use `ca.crt` for the CA certificate. Deprecate the usage of `caFile`, `certFile` and `keyFile` keys. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Check the auth secret for the `ca.crt` key for CA certificate data. `ca.crt` takes precdence over `caFile`. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
stefanprodan
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
.spec.certSecretRefHelmRepository and OCIRepository to use the keys expected in a Kubernetes Secret of type TLS,tls.crtandtls.key. Furthermore useca.crtfor specifying the CA certificate.Deprecate the usage of
certFile,keyFileandcaFilefor OCIRepository. BothcaFileandca.crtare supported for GitRepository with the latter taking precedence.Part of: fluxcd/flux2#4137