Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go-git to v5.10.0 #1271

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Upgrade go-git to v5.10.0 #1271

merged 1 commit into from
Nov 9, 2023

Conversation

makkes
Copy link
Member

@makkes makkes commented Oct 26, 2023 •
edited by stefanprodan
Loading

xref: go-git/go-git#866

fixes: #1239

@makkes makkes requested a review from pjbgf October 26, 2023 07:25
pjbgf
pjbgf approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco added area/git Git related issues and pull requests dependencies Pull requests that update a dependency labels Oct 26, 2023
@stefanprodan
Copy link
Member

stefanprodan commented Oct 26, 2023 •
edited
Loading

This doesn't seem to fix that issue, isn't the fix in go-git v5.10.0?

@makkes
Copy link
Member Author

makkes commented Oct 26, 2023

This doesn't see to do fix that issue, isn't the fix in go-git v5.10.0?

Ugh, I missed that go-git/go-git is also directly required here, too. Fixed.

@makkes
Copy link
Member Author

makkes commented Oct 26, 2023

I shall add a regression test...

@makkes
Copy link
Member Author

makkes commented Oct 30, 2023

It's really tought to add a proper regression test here because I'd bascially have to simulate the exact output from the SSH-Server.

@pjbgf
Copy link
Member

pjbgf commented Oct 30, 2023

@makkes I wonder whether it is worth building a simple SSH server based off go-git (like this) for the tests.

@stefanprodan stefanprodan changed the title Upgrade pkg/{git,git/gogit} Upgrade go-git to v5.10.0 Nov 7, 2023
@stefanprodan
Copy link
Member

@makkes can you please rebase so we can merge this. Given that testing is quite complicated we can do this in a diffrent PR.

Upgrade pkg/{git,git/gogit} and go-git/go-git
bbfe866 
fixes #1239

Signed-off-by: Max Jonas Werner <mail@makk.es>
@makkes makkes mentioned this pull request Nov 8, 2023
Open
@makkes
Copy link
Member Author

makkes commented Nov 8, 2023

Rebased and created #1279 to track tests.

@makkes makkes merged commit 8b0eccd into main Nov 9, 2023
10 checks passed
@makkes makkes deleted the upgrade-git-gogit branch November 9, 2023 11:10
@stefanprodan
Copy link
Member

@makkes can you please do the same update in image-automation-controller

@makkes
Copy link
Member Author

makkes commented Nov 17, 2023

@makkes can you please do the same update in image-automation-controller

fluxcd/image-automation-controller#602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@pjbgf pjbgf pjbgf approved these changes

Assignees
No one assigned
Labels
area/git Git related issues and pull requests dependencies Pull requests that update a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cryptic error message when git is not available
4 participants
@makkes @stefanprodan @pjbgf @hiddeco