Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement .spec.ref.semverFilter in OCIRepository API #1407

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Implement .spec.ref.semverFilter in OCIRepository API #1407

merged 2 commits into from
Mar 29, 2024

Conversation

souleb
Copy link
Member

@souleb souleb commented Mar 18, 2024

fixes #1391

If implemented a semVer filter regex can be declared in conjunction with a semver range in the OCIRepository spec.Reference.

@souleb souleb changed the title Introduce a semVer filter in OCIRepository Introduce a semVer filter in OCIRepository API Mar 18, 2024
@souleb souleb added area/oci OCI related issues and pull requests area/api API related issues and pull requests labels Mar 18, 2024
@souleb souleb force-pushed the add-semverfilter-to-ocirepo branch 3 times, most recently from adfc46d to 91dfdc2 Compare March 19, 2024 08:59
stefanprodan
stefanprodan reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this field to the API docs and write an example for RC filtering.

@souleb souleb force-pushed the add-semverfilter-to-ocirepo branch from 78e4abc to faf6be9 Compare March 25, 2024 21:56
stefanprodan
stefanprodan approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🏅

@souleb
Introduce a semver filter in OCIRepository
10434e7 
If implemented a semver filter regex can be declared in conjuction with
a semver range in the OCIRepository `spec.Reference`

Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb
adding an example for semverFilter in the the documentation
6d7189d 
Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb force-pushed the add-semverfilter-to-ocirepo branch from faf6be9 to 6d7189d Compare March 27, 2024 23:10
@souleb souleb merged commit 74c5f99 into main Mar 29, 2024
10 checks passed
@souleb souleb deleted the add-semverfilter-to-ocirepo branch March 29, 2024 09:25
@tabs-not-spaces
Copy link

Is there an ETA for when the next main release will ship? Desperate for this feature!!

@souleb
Copy link
Member Author

souleb commented Mar 29, 2024

It is planned for April.

@stefanprodan stefanprodan changed the title Introduce a semVer filter in OCIRepository API Implement .spec.ref.semverFilter in OCIRepository API Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/api API related issues and pull requests area/oci OCI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ref.semverFilter to OCIRepository API
3 participants
@souleb @tabs-not-spaces @stefanprodan