Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to crypto/ssh for parsing of private keys #339

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Apr 14, 2021

Key was generated with

ssh-keygen -t ed25519 -C "<email>@gmail.com"

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

@somtochiama somtochiama changed the title Test for Auth Method fails with some private keys Test for Auth Method fails for some private keys Apr 14, 2021
pkg/git/gogit/transport.go Outdated Show resolved Hide resolved
@somtochiama somtochiama marked this pull request as ready for review April 14, 2021 16:25
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please smash your commits together? 🌻

@stefanprodan
Copy link
Member

What does this PR do? By the looks of it, this is not just adding a test but a new feature?

@hiddeco
Copy link
Member

hiddeco commented Apr 15, 2021

No, it improves the previously added feature in #338 to support more key formats.

@hiddeco hiddeco changed the title Test for Auth Method fails for some private keys Switch to crypto/ssh for parsing of private keys Apr 15, 2021
@stefanprodan
Copy link
Member

Thanks, I missed the previous PR.

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan merged commit 82fdc24 into fluxcd:main Apr 19, 2021
pjbgf pushed a commit to pjbgf/source-controller that referenced this pull request Jul 31, 2022
Use of MUSL was a temporary solution to mitigate cross-platform
issues while building openssl and libssh2. Since Unmanaged transport has
been deprecated, openssl and libssh2 dependencies are no longer required
and by extension MUSL.

Enables libgit2 threadless support and provides a regression assurance
for image-automation-controller/fluxcd#339.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants