Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitRepository include for nested paths #367

Merged
merged 1 commit into from
May 28, 2021
Merged

Fix GitRepository include for nested paths #367

merged 1 commit into from
May 28, 2021

Conversation

stefanprodan
Copy link
Member

Bug fixes:

  • when setting toPath to a nested one, it errors out with no such file or directory, fixed by creating the parent dir
  • docs were not in sync with the actual API, replaced to/from with toPath/fromPath

@stefanprodan
Fix GitRepository include for nested paths
add5444 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added bug Something isn't working area/git Git related issues and pull requests labels May 28, 2021
@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label May 28, 2021
@stefanprodan stefanprodan merged commit 48efbd1 into main May 28, 2021
@stefanprodan stefanprodan deleted the fix-include branch May 28, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillebaba phillebaba phillebaba approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests area/git Git related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @phillebaba