Use ObjectKeyFromObject instead of ObjectKey #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controller-runtime's client package provides ObjectKeyFromObject() to extract NamespacedName from a given object. ObjectKey() in internal/util package is a helper for the same. Replace the internal helper with controller-runtime's helper for the same. Signed-off-by: Sunny <darkowlzz@protonmail.com>
|
@darkowlzz if this gets merged, would you mind opening PRs in the other repos, too, if needed (helm-controller, kustomize-controller, flux2, etc.)? |
@makkes Sure, I can do that. Thanks 🙂 |
hiddeco
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
This should be used everywhere else already (iirc the internal method here predates the utility in controller-runtime), thank you @darkowlzz 🌞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller-runtime's client package provides
ObjectKeyFromObject()toextract NamespacedName from a given object.
ObjectKey()ininternal/util package is a helper for the same. Replace the internal
helper with controller-runtime's helper for the same.