Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick bug fixes from reconciler refactor branch #417

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Aug 5, 2021

The cherry-picked commits in this PR can safely be introduced in the current state of main as they do not rely on any of the refactored logic, but rather fix things that surfaced while more tests were added during the refactor.

Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
This ensures the checksum is predictable, and not influenced by e.g.
different runtime configuration settings, or FS specific data.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco changed the title Cherry-pick fixes from reconciler-dev branch Cherry-pick bug fixes from reconciler refactor branch Aug 5, 2021
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@hiddeco hiddeco merged commit c30b940 into main Aug 5, 2021
@hiddeco hiddeco deleted the cherry-pick-fixes branch August 5, 2021 10:57
@hiddeco hiddeco added the bug Something isn't working label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants