Bump libgit2 to 1.3.0 and git2go to V33. #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream breaking changes introduced since git2go@V31: - git2go.ErrorCode was deprecated in favour of the native error type. - FetchOptions no longer expects a pointer, but rather the actual value of git2go.FetchOptions. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
This adds a test to detect any regression in libgit2's ED25519 key support. go-git supports ED25519 but not the current version of libgit2 used in flux. The updates to libgit2 in v1.2.0 adds support for ED25519. This test would help ensure the right version of libgit2 is used. Signed-off-by: Sunny <darkowlzz@protonmail.com> Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
force-pushed
the
bump-libgit2
branch
2 times, most recently
from
a1d9588
to
764e9be
Compare
Streamline the process of generating images by using a libgit source image that has pre-built static libraries. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
changed the title
|
The initial tests on this PR have worked fine so far. But given the short timeline to get |
Merged
relu
requested changes
Jan 27, 2022
| @@ -1,9 +1,9 @@ | |||
| ARG BASE_VARIANT=bullseye | |||
| ARG GO_VERSION=1.17.5 | |||
| ARG GO_VERSION=1.17.6 | |||
There was a problem hiding this comment.
Please change this to match the build image.
Suggested change
| ARG GO_VERSION=1.17.6 | |
| ARG GO_VERSION=1.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399 fluxcd/image-automation-controller#298
Relates to #397 #490 fluxcd/image-automation-controller#186 fluxcd/image-automation-controller#281
Depends on fluxcd/golang-with-libgit2#17