Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure git status is checked at the correct time #575

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Feb 9, 2022

The previous version would verify git status at time of make verify execution, but before all its dependencies were executed.
If one of the dependencies resulted in a dirty git, the check would still pass.

This resulted on false negatives, as mentioned on #574 (comment).

@pjbgf pjbgf force-pushed the fix-push branch 2 times, most recently from 3ff25a4 to 38ad635 Compare February 9, 2022 19:30
@hiddeco hiddeco added the area/ci CI related issues and pull requests label Feb 10, 2022
@pjbgf pjbgf marked this pull request as draft February 10, 2022 12:45
@pjbgf pjbgf added this to the GA milestone Apr 22, 2022
The previous version would verify git status at time of `make verify` execution, but before all its dependencies executed.
If one of the dependencies resulted in a dirty git, the check would still pass.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf marked this pull request as ready for review May 9, 2022 15:04
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf merged commit 1a06b7a into fluxcd:main May 9, 2022
@pjbgf pjbgf deleted the fix-push branch May 9, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants