libgit2: fixes issues when using Managed Transport for BitBucket and Azure DevOps repositories #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 10, 2022 19:54
Public bitbucket.org accounts do not support concurrent connections, making the controller to stumble upon itself with long-running connections, specially if more than one GitRepository is defined. To avoid such problems, bitbucket is now handled as single-use connections, which seems to improve its stability, although may still generate the occasional ssh.Dial TimeOut when a new connection takes places whilst an another is still established. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Managed transport now defines its own protocols, providing the flexibility of opt-in/out per repository. The feature switch now controls the auto upgrade from normal protocols (http, https and ssh) into managed protocols (http+managed, https+managed and ssh+managed). The use of the feature switch matches the previous behaviour, with the difference that now users are allowed to try Managed Transport for a connection at a time, regardless of the feature switch status. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
DevOps requires the Git protocol capabilities (e.g. multi_ack and multi_ack_detailed) that are not fully supported by libgit2/git2go in managed transport mode. This disables the auto upgrade feature for Azure DevOps repositories, but still allow for opt-in in case users want to force the use of Managed Transport. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
| // DevOps requires the Git protocol capabilities (e.g. multi_ack | ||
| // and multi_ack_detailed) that are not fully supported by libgit2/git2go | ||
| // in managed transport mode. | ||
| "dev.azure.com", |
There was a problem hiding this comment.
Does this means we’ll not be able to get rid of libssh and openssl dependencies due to Azure DevOps?
There was a problem hiding this comment.
For the time being, yes. I will create an issue to further detail the problem and potential consequences.
|
PR #713 supersedes this, as it reduces complexity whilst increasing reliability of the managed transport. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
multi_ackandmulti_ack_detailed.